Skip to content

Conversation

@roomote
Copy link
Contributor

@roomote roomote bot commented Jul 15, 2025

Summary

This PR fixes issue #5756 where the search_and_replace tool was using "Approve"/"Reject" buttons instead of "Save"/"Cancel" buttons like other write tools, causing textarea content to be cleared instead of sent to the chat.

Changes

  • Added searchAndReplace to the case statement that handles write tools in ChatView.tsx
  • This ensures search_and_replace uses "Save"/"Cancel" buttons like other write tools (editedExistingFile, appliedDiff, newFileCreated, insertContent)
  • Maintains consistent UX where users can provide feedback in the textarea and it gets sent to the chat when clicking buttons

Testing

  • ✅ All existing tests pass
  • ✅ Linting and type checking pass
  • ✅ Build completes successfully

Impact

  • Fixes inconsistent button behavior for search_and_replace tool
  • Users can now provide feedback that gets sent to the chat instead of being lost
  • Maintains consistency with other write tools

Fixes #5756


Important

Fixes button inconsistency for search_and_replace tool in ChatView.tsx by using "Save"/"Cancel" buttons.

  • Behavior:
    • Adds searchAndReplace to the case statement in ChatView.tsx to use "Save"/"Cancel" buttons instead of "Approve"/"Reject".
    • Ensures textarea content is sent to chat when buttons are clicked, maintaining consistency with other write tools.
  • Testing:
    • All existing tests pass.
    • Linting and type checking pass.
    • Build completes successfully.

This description was created by Ellipsis for 4c215a0. You can customize this summary. It will automatically update as commits are pushed.

…ency

- Add searchAndReplace to the case that handles write tools
- This ensures search_and_replace uses Save/Cancel buttons like other write tools
- Fixes issue where Approve/Reject buttons cleared textarea content instead of sending it to chat
- Maintains consistent UX across all write operations

Fixes #5756
@roomote roomote bot requested review from cte, jr and mrubens as code owners July 15, 2025 19:30
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Jul 15, 2025
@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Jul 15, 2025
@daniel-lxs daniel-lxs moved this from Triage to Roomote/renovate BOT in Roo Code Roadmap Jul 15, 2025
@github-project-automation github-project-automation bot moved this from Roomote/renovate BOT to Done in Roo Code Roadmap Jul 16, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

"Approve" or "Reject" buttons clears textarea and does not send text to the chat/model

3 participants